101 lines
3.8 KiB
Markdown
101 lines
3.8 KiB
Markdown
|
# Code Review: FrontendDev P1 submit() 重构
|
||
|
|
|
||
|
|
**Reviewer**: BackendArchitect
|
||
|
|
**Date**: 2026-04-15
|
||
|
|
**Files Reviewed**:
|
||
|
|
- `shopxo/app/plugins/vr_ticket/view/goods/ticket_detail.html` (lines 389-443)
|
||
|
|
- `shopxo/app/plugins/vr_ticket/service/SeatSkuService.php`
|
||
|
|
|
||
|
|
## Summary
|
||
|
|
|
||
|
|
P1 submit() 重构与 BackendArchitect 的 P0-B BatchGenerate() 接口对齐。
|
||
|
|
|
||
|
|
## Interface Contract Check
|
||
|
|
|
||
|
|
### Backend P0-B returns:
|
||
|
|
```php
|
||
|
|
// SeatSkuService::BatchGenerate() returns:
|
||
|
|
'data' => [
|
||
|
|
'total' => count($seats),
|
||
|
|
'generated' => $generatedCount,
|
||
|
|
'batch' => $totalBatches,
|
||
|
|
'spec_base_id_map' => ['A_1' => 2001, 'A_2' => 2002, ...] // seatId => int
|
||
|
|
]
|
||
|
|
```
|
||
|
|
|
||
|
|
### Frontend P1 uses:
|
||
|
|
```javascript
|
||
|
|
// ticket_detail.html:417
|
||
|
|
var specBaseId = self.specBaseIdMap[seat.seatKey] || self.sessionSpecId;
|
||
|
|
```
|
||
|
|
|
||
|
|
### Key format alignment:
|
||
|
|
- Backend generates: `seatId = rowLabel . '_' . colNum` → `"A_1"`, `"B_10"` etc.
|
||
|
|
- Backend parses back via: `preg_match('/^([A-Za-z]+)(\d+)排(\d)座$/')` → extracts `rowLabel` and `colNum`
|
||
|
|
- Frontend sets: `seatKey = rowLabel + '_' + colNum` (line: `rowLabel + '_' + colNum`)
|
||
|
|
- ✅ **Format matches**
|
||
|
|
|
||
|
|
### Frontend accesses specBaseIdMap as flat integer:
|
||
|
|
```javascript
|
||
|
|
// ticket_detail.html:417
|
||
|
|
var specBaseId = self.specBaseIdMap[seat.seatKey] || self.sessionSpecId;
|
||
|
|
```
|
||
|
|
- ✅ Fixed from `(obj||{}).spec_base_id` → flat integer (commit `96337bc84`)
|
||
|
|
|
||
|
|
## goods_params Structure Check
|
||
|
|
|
||
|
|
```javascript
|
||
|
|
{
|
||
|
|
goods_id: self.goodsId,
|
||
|
|
spec_base_id: parseInt(specBaseId) || 0, // ✅ seat-level SKU
|
||
|
|
stock: 1, // ✅ 1 per seat (ShopXO-native)
|
||
|
|
extension_data: JSON.stringify({
|
||
|
|
attendee: seatAttendee,
|
||
|
|
seat: { seatKey, label, price, rowLabel, colNum, row, col }
|
||
|
|
})
|
||
|
|
}
|
||
|
|
```
|
||
|
|
- ✅ `stock: 1` — correct for seat-level inventory
|
||
|
|
- ✅ `extension_data` carries full seat context for `onOrderPaid()` validation
|
||
|
|
- ✅ Each seat gets its own goods_params entry → each becomes one order_goods row in ShopXO
|
||
|
|
|
||
|
|
## Fallback Strategy
|
||
|
|
|
||
|
|
```javascript
|
||
|
|
var specBaseId = self.specBaseIdMap[seat.seatKey] || self.sessionSpecId;
|
||
|
|
```
|
||
|
|
- ✅ Graceful degradation: if SKU not generated yet (Plan B transition), uses zone-level SKU
|
||
|
|
- ✅ Prevents checkout breakage during rollout
|
||
|
|
|
||
|
|
## Seat Label Format
|
||
|
|
|
||
|
|
Frontend generates labels via: `` `${seat.rowLabel}排${seat.colNum}座` `` (e.g., `"A排1座"`)
|
||
|
|
Backend regex: `/^([A-Za-z]+)(\d+)排(\d)座$/`
|
||
|
|
- Row: 1+ letters (A, AA, etc.) — captured by `(\d+)`
|
||
|
|
- Col: single digit 1-9 — captured by `(\d)`
|
||
|
|
- ✅ Column numbers > 9 won't appear in `{rowLabel}排{colNum}座` format
|
||
|
|
- ✅ Regex correctly handles standard seat labels
|
||
|
|
|
||
|
|
## seat.price Source
|
||
|
|
|
||
|
|
Frontend sets `seat.price` during seat selection (likely from seatMap data).
|
||
|
|
Backend BatchGenerate uses same price source: `seatInfo['price']` → `sectionPrices[zone]` fallback.
|
||
|
|
- ✅ Price sources align between frontend (UI) and backend (SKU generation)
|
||
|
|
|
||
|
|
## Findings
|
||
|
|
|
||
|
|
### Minor: seat_key format note
|
||
|
|
The specBaseIdMap key format `row_col` (e.g., `A_1`) is consistent throughout. No issues.
|
||
|
|
|
||
|
|
### Pending Verification (Container)
|
||
|
|
The following need live testing in ShopXO container:
|
||
|
|
1. `initGoodsSpecs(112)` → confirms `is_exist_many_spec=1` + 4 spec_types
|
||
|
|
2. `BatchGenerate(112, $templateId)` → confirms seat-level SKUs in DB
|
||
|
|
3. Full checkout flow: seat selection → submit → BuyGoods → order creation
|
||
|
|
|
||
|
|
## Verdict
|
||
|
|
|
||
|
|
`[APPROVE]` — P1 implementation correctly aligns with P0-B interface contract. The seat-level goods_params approach is sound and leverages ShopXO's native multi-row goods_params support. One minor note: ensure `seatMap.sections` (price source) is populated in the frontend seat data so BatchGenerate has price information.
|
||
|
|
|
||
|
|
**Action Required**: FrontendDev should sync worktree with latest main (`a0690fdd5`) to pick up bug fixes.
|